Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main() API to entrance package #8

Merged
merged 1 commit into from
May 6, 2020

Conversation

LewisGaul
Copy link

@LewisGaul LewisGaul commented May 5, 2020

… and use this rather than importing __main__ in examples.

Bear in mind this uses sys.argv, and isn't customisable (it's just running __main__.py after all). I think this is fine, since this is intended as a quick and simple option (and modifying sys.argv is still an option).

See discussion on #6.

@simonchatts simonchatts merged commit 720a787 into ensoft:master May 6, 2020
@simonchatts
Copy link
Contributor

Thanks Lewis! Looks good to me.

@LewisGaul LewisGaul deleted the main-api branch May 6, 2020 14:52
@simonchatts
Copy link
Contributor

BTW I've done a new PyPI release with these two PRs.

@LewisGaul
Copy link
Author

BTW I've done a new PyPI release with these two PRs.

Excellent thanks, wasn't blocking me but good to have them out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants