-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/proto custom type #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
reviewed
Apr 11, 2021
entproto/field.go
Outdated
Comment on lines
49
to
60
func OverrideType(typ descriptorpb.FieldDescriptorProto_Type) FieldOption { | ||
return func(p *pbfield) { | ||
p.OverrideType = typ | ||
} | ||
} | ||
|
||
// OverrideTypeName sets the pb descriptors type name, needed if the OverrideType attribute is TYPE_ENUM or TYPE_MESSAGE. | ||
func OverrideTypeName(n string) FieldOption { | ||
return func(p *pbfield) { | ||
p.OverrideTypeName = n | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but remove the Override
string from this function.
Also, consider adding a usage example in the godoc. I use it a lot.
Suggested change
func OverrideType(typ descriptorpb.FieldDescriptorProto_Type) FieldOption { | |
return func(p *pbfield) { | |
p.OverrideType = typ | |
} | |
} | |
// OverrideTypeName sets the pb descriptors type name, needed if the OverrideType attribute is TYPE_ENUM or TYPE_MESSAGE. | |
func OverrideTypeName(n string) FieldOption { | |
return func(p *pbfield) { | |
p.OverrideTypeName = n | |
} | |
} | |
func Type(typ descriptorpb.FieldDescriptorProto_Type) FieldOption { | |
return func(p *pbfield) { | |
p.Type = typ | |
} | |
} | |
// TypeName sets the pb descriptors type name, needed if the OverrideType attribute is TYPE_ENUM or TYPE_MESSAGE. | |
func TypeName(n string) FieldOption { | |
return func(p *pbfield) { | |
p.TypeName = n | |
} | |
} |
a8m
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prep for ent/ent#1350, adding some flexibilty for users to modify the type mapping between ent and pb.