This repository has been archived by the owner on May 14, 2024. It is now read-only.
Improve exif parsing #1066
Merged
Improve exif parsing #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5e5a9a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f8b131d6.bada-frame.pages.dev |
| Branch Preview URL: | https://improve-exif-parsing.bada-frame.pages.dev |
ua741
approved these changes
Apr 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extract the XMP DateCreated tag and use it as a fallback in case other
DateTimeOriginaltag is missingPriortized XMP
DateCreatedover EXIFDateTimeDigizited(in code referred as CreateDate by the lib)There is an issue in the EXIF library where trying to just pick
DateCreatedtag is not working hence, extracted had to extract everything and then filter out needed tagshad custom location parsing logic because disabling pick prevents us from using the internal location parser
Test Plan