Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Pass a C-contiguous array to points_in_polygon #409

Merged
merged 1 commit into from
Jul 2, 2018
Merged

FIX: Pass a C-contiguous array to points_in_polygon #409

merged 1 commit into from
Jul 2, 2018

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Jul 2, 2018

Fixes #408

corranwebster
corranwebster approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Are there other places where we call points_in_polygon that may have similar problems?

@jwiggins
Copy link
Member Author

jwiggins commented Jul 2, 2018

I had the same question. This is the only other call to points_in_polygon:

$ grin points_in_polygon
./chaco/polygon_plot.py:
   12 : from kiva.api import points_in_polygon
  138 :         if points_in_polygon([data_pt], poly)[0] == 1:

It's passing a list, which gets passed through numpy.asarray before constructing a view. I think it should be OK.

@jwiggins jwiggins merged commit 15bf6bf into master Jul 2, 2018
@jwiggins jwiggins deleted the fix/408 branch July 2, 2018 09:04
This was referenced Jul 3, 2018
Merged
Merged
jwiggins added a commit that referenced this pull request Jul 12, 2018
@jwiggins
FIX: Pass a C-contiguous array to points_in_polygon (#409)
0bfc04a
@jwiggins jwiggins mentioned this pull request Jul 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwiggins @corranwebster