MAINT: add 3.11 test #861

homosapien-lcy · 2023-03-16T07:23:15Z

With new python tests, we also want to test and make sure all examples can work in 3.11. Since 3.11 is not available in EDM, pypi is tested. closes #860

homosapien-lcy · 2023-03-17T09:08:00Z

An error happened when running on python 3.6 which is similar to what happened in SciMath (enthought/scimath#170)

Problem description:
If python 3.6 is added to the pypi test, it will generate a "The version '3.6' with architecture 'x64' was not found for Ubuntu 22.04." error.

Reproduction steps:
Add 3.6 to .github/workflows/test-with-pypi.yml.

Expected behavior:
Pass the github workflows test.

OS: Ubuntu 22.04

Python version: 3.6

The tests with other python versions are past though

dpinte · 2023-03-23T09:38:13Z

.github/workflows/test-with-pypi.yml

+      matrix:
+        os: ['ubuntu-latest']
+        toolkit: ['pyside6']
+        python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']


@mdickinson any preference on which versions to test? Do really want all or should we use 3.8 and 3.11 only?

I think I'd keep all of them here; this is only testing on Ubuntu with a single toolkit, so we don't have a combinatorial explosion of jobs in the matrix.

We definitely want the extremes (3.7 and 3.11), along with the versions that we care about for EDM (so 3.8). At that point, we could drop 3.9 and 3.10, but I think we should have at least one workflow that exercises the test suite on 3.9 and 3.10, and this one doesn't look like a bad target for that.

Dropping 3.7 from the workflow would be reasonable if we're also dropping 3.7 support for Chaco in general. If that's what we want to do then that seems fine to me - 3.7 EOL is June this year.

@dpinte Ah, sorry; I did miss that there was a second job below that also goes through all combinations. As a compromise, I'd suggest testing on all 5 versions on Ubuntu, but limiting ourselves to 3.8 and 3.11 on Windows and macOS.

mdickinson · 2023-03-23T09:48:13Z

.github/workflows/test-with-pypi.yml

+      matrix:
+        os: ['macos-latest', 'windows-latest']
+        toolkit: ['pyside6']
+        python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']


Suggest dropping down to just 3.8 and 3.11 for this job.

mdickinson · 2023-03-23T09:49:19Z

.github/workflows/test-with-pypi.yml

+
+jobs:
+
+  # Test against PyPI packages


What's the rationale for splitting this into two separate jobs?

Do you mean why separate into ubuntu and others? I think the installation command is different (sudo apt-get install), also we might want to test with different python versions on different platforms.

Yes, that's what I meant. There are trade-offs here; on one hand, having two separate jobs that do the same thing is a bit of a violation of DRY. On the other hand, it may make sense if there are sufficient differences. I leave it to you.

For the apt-get instructions, it's easy to make that step conditional so that it only runs on Ubuntu systems.

homosapien-lcy · 2023-03-24T06:44:45Z

testing procedure:
1 env setup:
python3.11 -m venv --clear ~/.venvs/p311 && source ~/.venvs/p311/bin/activate
2 clone
git clone git@github.com:enthought/chaco.git
3 install dependencies
brew install portaudio (for mac)
pip install configobj
pip install pygments
pip install pyaudio
pip install traitsui
pip install pyparsing
pip install pyside6
pip install scikit-learn
4 install package
python3.11 -m pip install -e .

chaco/examples/demo/:
depth: NotImplementedError: the 'null' toolkit does not implement this method
domain_limits: NotImplementedError: the 'null' toolkit does not implement this method
financial_plot_dates: NotImplementedError: the 'null' toolkit does not implement this method
aspect_ratio: NotImplementedError: the 'null' toolkit does not implement this method
multiaxis: NotImplementedError: the 'null' toolkit does not implement this method
multiaxis_using_Plot: NotImplementedError: the 'null' toolkit does not implement this method
logo: SUCCESS
financial_plot: NotImplementedError: the 'null' toolkit does not implement this method
multi_line_plot: NotImplementedError: the 'null' toolkit does not implement this method
noninteractive: SUCCESS (image generated)
world_map: urllib.error.HTTPError: HTTP Error 404: Not Found

chaco/examples/tutorials/:
tutor: ModuleNotFoundError: No module named 'configobj'
tutorial1: SUCCESS (image generated)
tutorial2: NotImplementedError: the 'null' toolkit does not implement this method
tutorial2_ipython: NotImplementedError: the 'null' toolkit does not implement this method
tutorial3: NotImplementedError: the 'null' toolkit does not implement this method
tutorial4: NotImplementedError: the 'null' toolkit does not implement this method
tutorial5: NotImplementedError: the 'null' toolkit does not implement this method
tutorial6: NotImplementedError: the 'null' toolkit does not implement this method
tutorial7: NotImplementedError: the 'null' toolkit does not implement this method
tutorial8: NotImplementedError: the 'null' toolkit does not implement this method
tutorial9: NotImplementedError: the 'null' toolkit does not implement this method
tutorial9b: NotImplementedError: the 'null' toolkit does not implement this method
tutorial10: NotImplementedError: the 'null' toolkit does not implement this method
tutorial10b: NotImplementedError: the 'null' toolkit does not implement this method
tutorial11: NotImplementedError: the 'null' toolkit does not implement this method

chaco/examples/user_guide/:
h_plot_container_add_multiple_times: NotImplementedError: the 'null' toolkit does not implement this method
grid_plot_container: NotImplementedError: the 'null' toolkit does not implement this method
h_plot_container: NotImplementedError: the 'null' toolkit does not implement this method
power_function_example: NotImplementedError: the 'null' toolkit does not implement this method
h_plot_container_colorbar: NotImplementedError: the 'null' toolkit does not implement this method
overlay_container_inset: NotImplementedError: the 'null' toolkit does not implement this method

homosapien-lcy · 2023-03-27T08:02:05Z

Full results in https://docs.google.com/spreadsheets/d/1vvkQgbG1_KrY-7y9h5HGSl15eocL2o1Av4y4b1iUCKg/edit#gid=393321095

corranwebster · 2023-03-27T08:05:27Z

python3.11 -m pip install -e .

You probably should be doing python3.11 -m pip install -e ".[examples]" or something similar to bring in pandas and scipy example dependencies.

homosapien-lcy · 2023-03-27T08:37:41Z

python3.11 -m pip install -e .

You probably should be doing python3.11 -m pip install -e ".[examples]" or something similar to bring in pandas and scipy example dependencies.

Hi Corran: thanks for the advice. Could you give an example of what should be in the ".[examples]"? This repositery for instance

homosapien-lcy · 2023-03-29T06:45:41Z

Full results updated in https://docs.google.com/spreadsheets/d/1R_HF86YJybiSqOLplDsk7-UiTmNJvdX4z3OjzW8Q6hQ/edit#gid=381404102 (add 120ish more tests)

corranwebster · 2023-04-06T07:11:40Z

.github/workflows/test-with-pypi.yml

+          sudo apt-get install libxcb-randr0
+          sudo apt-get install libxcb-render-util0
+          sudo apt-get install libxcb-xinerama0
+          sudo apt-get install libxcb-shape0


With the release of PySide 6.5, this will need this as well:

sudo apt-get install libxcb-cursor0

corranwebster · 2023-05-10T11:53:22Z

Closing in favour of #891

Chengyu Liu added 3 commits March 16, 2023 16:22

MAINT: add 3.11 test

1843f0b

add 3.11 package

1e0778a

add 3.11 test package

2f7de50

homosapien-lcy changed the title ~~MAINT: add 3.11 test~~ [WIP] MAINT: add 3.11 test Mar 16, 2023

Chengyu Liu added 13 commits March 16, 2023 16:32

fix typo

46c136c

remove 311 to add to pypi

66f3825

add pypi 3.11

d40348f

add extra package dependencies

ff7e0b7

add wheel and coverage

692d894

remove null

9b22da3

MAINT: add pyparsing

51e6771

add os

c67dd11

fix typo

fbd3dd5

run on all matrix

9a634ec

fix tests on other systems

7f88ce5

add all python versions

6ec2b4c

add 3.6

7b7877c

homosapien-lcy changed the title ~~[WIP] MAINT: add 3.11 test~~ MAINT: add 3.11 test Mar 17, 2023

remove test 3.6

d9b1741

homosapien-lcy requested a review from corranwebster March 17, 2023 09:25

dpinte reviewed Mar 23, 2023

View reviewed changes

mdickinson reviewed Mar 23, 2023

View reviewed changes

remove some test versions for windows and mac

3e4463b

corranwebster reviewed Apr 6, 2023

View reviewed changes

corranwebster closed this May 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MAINT: add 3.11 test #861

MAINT: add 3.11 test #861

homosapien-lcy commented Mar 16, 2023 •

edited

homosapien-lcy commented Mar 17, 2023 •

edited

dpinte Mar 23, 2023

mdickinson Mar 23, 2023

mdickinson Mar 23, 2023

mdickinson Mar 23, 2023

mdickinson Mar 23, 2023

mdickinson Mar 23, 2023

homosapien-lcy Mar 24, 2023

mdickinson Mar 27, 2023

homosapien-lcy commented Mar 24, 2023 •

edited

homosapien-lcy commented Mar 27, 2023

corranwebster commented Mar 27, 2023

homosapien-lcy commented Mar 27, 2023

homosapien-lcy commented Mar 29, 2023

corranwebster Apr 6, 2023

corranwebster commented May 10, 2023

MAINT: add 3.11 test #861

MAINT: add 3.11 test #861

Conversation

homosapien-lcy commented Mar 16, 2023 • edited

homosapien-lcy commented Mar 17, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

homosapien-lcy commented Mar 24, 2023 • edited

homosapien-lcy commented Mar 27, 2023

corranwebster commented Mar 27, 2023

homosapien-lcy commented Mar 27, 2023

homosapien-lcy commented Mar 29, 2023

Choose a reason for hiding this comment

corranwebster commented May 10, 2023

homosapien-lcy commented Mar 16, 2023 •

edited

homosapien-lcy commented Mar 17, 2023 •

edited

homosapien-lcy commented Mar 24, 2023 •

edited