Allow registering the dict->IContext adapters other than at import time. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
|
Depends on enthought/traits#145 |
# Via Ioannis Tziakos (1) and IoannisTziakos (1) * master: use the right environment variable we need cython after all more updates add etsdevtools in the installation install unittest2 when running under python 2.6 add blockcanvas in the setup add apptools in the trvis-ci configuration remove cython since it should not be required update travis configuration add a dev-requirements file add a coverage rc configuration Conflicts: .travis.yml
|
@pberkes, I have merged master back to this PR so that the updated travis configuration is picked up |
|
enthought/traits#145 has been merged -- this PR is ready for review |
|
I'd like to merge it tomorrow to match the merged traits PR. Then I'll make a PR on meta-ETS with the traits and codetools with both changes. |
pberkes
pushed a commit
that referenced
this pull request
Feb 28, 2014
Allow registering the dict->IContext adapters other than at import time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just registering the adapters from
dicttoIContextandICheckpointable, provideAdaptationOffersfor both, and introduce a function to register them to an adaptation manager of choice.This allows to use the adapters in a context where the adaptation manager is not the global one, or
where the adaptation manager is reset (e.g., unittesting).