Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted __cmp__() functions from repository #513

Closed
wants to merge 2 commits into from

Conversation

alexcalvo9
Copy link

Here I deleted the out of data cmp() functions in comtypes as stated in issue #512 as it is no longer supported

@alexcalvo9 alexcalvo9 closed this Feb 9, 2024
@junkmd
Copy link
Collaborator

junkmd commented Feb 12, 2024

Hi,

Why was this closed?
I think this pull request is helpful to the project.

@alexcalvo9
Copy link
Author

alexcalvo9 commented Feb 12, 2024 via email

@junkmd
Copy link
Collaborator

junkmd commented Feb 12, 2024

Hi,

Thank you for showing interest in this project.

The issue labeled as "good first issue" is based on the assumption that addressing it won't likely have a significant impact on the overall project, as mentioned in the issue description.

As stated in the issue, __cmp__ and cmp belong to the older world of Python and are no longer in use. Projects explicitly implementing cmp in Python 3.7 or later are probably rare. If such projects exist, I would suggest to them to use __eq__ instead.

Therefore, there's likely no need to worry about the proposed changes adversely affecting the project.

Your contributions are welcome. For areas that you may not understand, I trust that the community will provide assistance.

And I hope that this project proves to be helpful for you in obtaining credits.

@alexcalvo9
Copy link
Author

alexcalvo9 commented Feb 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants