Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerize Travis CI Builds #206

Merged
merged 10 commits into from
Sep 11, 2015
Merged

Containerize Travis CI Builds #206

merged 10 commits into from
Sep 11, 2015

Conversation

corranwebster
Copy link
Contributor

In preparation for Python 3 stuff.

@corranwebster
Copy link
Contributor Author

Well, that's not going to work since it calls out to travis_setup.sh which sudo's a bunch of stuff.

@jwiggins
Copy link
Member

The sudo commands are all for installing dependencies. If there was a clean way of installing everything in a venv, you could sidestep the need for root privs 😉

@jwiggins
Copy link
Member

Or... that. Fingers crossed!

@corranwebster
Copy link
Contributor Author

As expected, PIL seems unhappy. :(

@corranwebster
Copy link
Contributor Author

Why do we need to continue to support PIL again? Would it be OK to just to CI with Pillow going forward?

@corranwebster
Copy link
Contributor Author

Current state - pycairo is being painful, not sure about PIL.

itziakos
itziakos reviewed Sep 4, 2015
View reviewed changes
.travis.yml
- libfreetype6-dev
- libcairo2-dev
- python-cairo
- python-cairo-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the python-cairo-dev?

@itziakos
Copy link
Member

itziakos commented Sep 4, 2015

I would suggest that this PR waits for #208 before merging. I think it would be easier that way

@corranwebster
Copy link
Contributor Author

I agree on #208, but would like to prove out the containerized building in the meantime.

@itziakos
Copy link
Member

itziakos commented Sep 4, 2015

May I also suggest to start using codecov instead of coveralls?

after_success:
  - pip install codecov
  - codecov

itziakos
itziakos reviewed Sep 4, 2015
View reviewed changes
.travis.yml
- zlib1g-dev
- libpng-dev
- libfreetype6-dev
- libcairo2-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also not need to install this, we should let python-cairo bring any dependencies it needs.

@jwiggins
Copy link
Member

jwiggins commented Sep 5, 2015

#208 is merged

@corranwebster corranwebster changed the title [WIP] Containerize Travis CI Builds Containerize Travis CI Builds Sep 11, 2015
@corranwebster
Copy link
Contributor Author

OK, I think that this is done.

@itziakos
Copy link
Member

👍

itziakos added a commit that referenced this pull request Sep 11, 2015
@itziakos
Merge pull request #206 from enthought/enh/containerize-travis-ci
e47a3df 
Containerize Travis CI Builds
@itziakos itziakos merged commit e47a3df into master Sep 11, 2015
@itziakos itziakos deleted the enh/containerize-travis-ci branch September 11, 2015 17:31
@jwiggins
Copy link
Member

👍 Looks like a nice performance boost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corranwebster @jwiggins @itziakos