Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't barf if the g++ version string doesn't parse correctly #226

Merged
merged 1 commit into from
May 3, 2016

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented May 3, 2016

Fixes #220

@rkern
Copy link
Member

rkern commented May 3, 2016

LGTM pending CI.

@codecov-io
Copy link

codecov-io commented May 3, 2016

Current coverage is 35.35%

Merging #226 into master will not change coverage

@@             master       #226   diff @@
==========================================
  Files           211        211          
  Lines         18659      18659          
  Methods           0          0          
  Messages          0          0          
  Branches       2621       2621          
==========================================
  Hits           6596       6596          
  Misses        11543      11543          
  Partials        520        520          
  1. File ...ble/qt4/constants.py (not in diff) was modified. more

Powered by Codecov. Last updated by d0f1e67...759c93f

@jwiggins
Copy link
Member Author

jwiggins commented May 3, 2016

Thanks for looking @rkern. What about the codecov checks? Still ignoring those?

@corranwebster
Copy link
Contributor

I think we should ignore codecov checks for now - they've messed around with their infrastructure and until we have time to update we shouldn't worry too much about it.

@jwiggins
Copy link
Member Author

jwiggins commented May 3, 2016

In that case, I'm merging

@jwiggins jwiggins merged commit bab5b6a into master May 3, 2016
@jwiggins jwiggins deleted the fix/issue-220 branch May 3, 2016 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants