Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mess up the component bounds in HiDPI mode #635

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

jwiggins
Copy link
Member

Fixes #634

@stevenjkern
Copy link
Contributor

I can confirm that this fixes the issues seen when the bug was originally identified. 👍 👍

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like we need a 5.0.1?

@jwiggins jwiggins merged commit 69a635d into master Feb 26, 2021
@jwiggins jwiggins deleted the fix/component-refresh-hidpi branch February 26, 2021 10:58
@jwiggins
Copy link
Member Author

We definitely need a 5.0.1. Luckily 5.0.0 isn't in EDM yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HiDPI doubles size of components when a component is replaced
3 participants