Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "super" usage #789

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Update "super" usage #789

merged 1 commit into from
Apr 21, 2021

Conversation

rahulporuri
Copy link
Contributor

This PR updates super usage using automated regex-based search and replace. After the changes were made, we reviewed each of the changes to ensure that we were calling the right class before.

See enthought/traits#1280

This commit updates super usage using automated regex-based search and
replace. After the changes were made, we reviewed each of the changes to
ensure that we were calling the right class before.
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 575 to 576
# crappy... calling our parent's handler seems like a common traits
# event handling problem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this same thing when reviewing recent chaco PRs...

enable/scrolled.py Show resolved Hide resolved
@rahulporuri rahulporuri merged commit 6850385 into master Apr 21, 2021
@rahulporuri rahulporuri deleted the cln/update-super-usage branch April 21, 2021 13:44
@rahulporuri rahulporuri moved this from In progress to Done in Enthought OSS Q2 2021 Apr 21, 2021
@rahulporuri rahulporuri moved this from Done to Sprint 2 : 19 April - 30 April 2021 in Enthought OSS Q2 2021 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q2 2021
  
Sprint 2 : 19 April - 30 April 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants