Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is currently broken #486

Closed
mdickinson opened this issue Oct 17, 2022 · 1 comment · Fixed by #487
Closed

CI is currently broken #486

mdickinson opened this issue Oct 17, 2022 · 1 comment · Fixed by #487
Labels
type: bug

Comments

@mdickinson
Copy link
Member

Our continuous integration is broken on the main branch. We should fix this as a matter of priority before merging any other changes to main.

The cause appears to be enthought/pyface#1163

I don't have time to investigate further, but it seems at least plausible that this is a regression with PySide 6.4.0. If so, we could restrict to an older version of PySide 6, with appropriate comments linking to the Pyface issue so the the version restriction can be removed once this is fixed in either Pyface or PySide 6.
@mdickinson
Copy link
Member Author

Example failing test run: https://github.com/enthought/envisage/actions/runs/3264826259

@mdickinson mdickinson mentioned this issue Oct 18, 2022
Merged
mdickinson added a commit that referenced this issue Feb 6, 2023
@mdickinson
Pin PySide6 version (#487)
022d29e 
CI is currently failing thanks to a backwards incompatible change in
PySide6 6.4.0, which affects Pyface. We'll pin the PySide6 version until
Pyface has a chance to adapt to the PySide6 changes.

Fixes #486.

(cherry picked from commit 5cddb45)
mdickinson added a commit that referenced this issue Feb 7, 2023
@mdickinson
Pin PySide6 version (#487)
4deb0a5 
CI is currently failing thanks to a backwards incompatible change in
PySide6 6.4.0, which affects Pyface. We'll pin the PySide6 version until
Pyface has a chance to adapt to the PySide6 changes.

Fixes #486.

(cherry picked from commit 5cddb45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin PySide6 version enthought/envisage
1 participant
@mdickinson