Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test eggs for Python 3.9; remove eggs for Python 2.7 #289

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Add test eggs for Python 3.9; remove eggs for Python 2.7 #289

merged 1 commit into from
Jun 2, 2020

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jun 2, 2020 •
edited
Loading

This PR adds test eggs for Python 3.9 and removes the existing eggs for Python 2.7

Longer term, we should try to come up with a better solution that doesn't involve recreating eggs for each Python version.

Closes #286

rahulporuri
rahulporuri approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 23ea988 into master Jun 2, 2020
@mdickinson mdickinson deleted the fix/py39-test-eggs branch June 2, 2020 11:48
@opoplawski opoplawski mentioned this pull request Feb 2, 2021
Closed
@mdickinson mdickinson mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need test eggs for python 3.9
2 participants
@mdickinson @rahulporuri