Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build machinery to support Python 3.8 and PySide 6 #477

Merged
merged 37 commits into from
Aug 12, 2022
Merged

Update build machinery to support Python 3.8 and PySide 6 #477

merged 37 commits into from
Aug 12, 2022

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Aug 11, 2022 •
edited
Loading

This PR extends the build machinery to support Python 3.8 and PySide 6, and does general cleanup and streamlining of the GitHub Actions workflows.

Notable changes:

  • I've added a minimal pyproject.toml file.
  • For EDM-based workflows, we use the GitHub Actions Python for our bootstrap environment instead of creating an EDM bootstrap environment; creation and population of the bootstrap environment takes ~5s.
  • For the wxPython workflow, I've disabled Python 3.6: the workflow only runs on Python 3.8. The pip install of wxPython 4.2.0 on Python 3.6 appears to be broken.
  • I've added platform-specific skips for a couple of troublesome tests; there are linked issues for those skips
  • All workflows can now be run manually

@mdickinson mdickinson marked this pull request as draft August 11, 2022 11:12
@mdickinson
Copy link
Member Author

Marking as draft: I'm aiming to combine this with general build system updates.

@mdickinson mdickinson changed the title Add a minimal pyproject.toml Update build machinery to support Python 3.8 and PySide 6 Aug 11, 2022
@mdickinson mdickinson mentioned this pull request Aug 11, 2022
Closed
@mdickinson mdickinson marked this pull request as ready for review August 11, 2022 16:22
mdickinson
mdickinson commented Aug 11, 2022
View reviewed changes
envisage/ui/tasks/tests/test_tasks_application.py
@requires_gui
class TestTasksApplication(unittest.TestCase):
def setUp(self):
self.tmpdir = tempfile.mkdtemp()
self.addCleanup(shutil.rmtree, self.tmpdir)

@unittest.skipUnless(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by cleanup; this skip condition could only be triggered under Python 2.

corranwebster
corranwebster approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. etstool.py seems to be working appropriately.

@mdickinson
Copy link
Member Author

Thanks. Updating branch protections so that I can merge.

@mdickinson mdickinson merged commit d3a808b into main Aug 12, 2022
@mdickinson mdickinson deleted the add-pyproject-toml branch August 12, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdickinson @corranwebster