Reimplement fix savefig with size and magnification - step 0 [WIP] #346

kitchoi · 2016-04-21T10:15:05Z

Reimplement part of #331
Tests fail as the fix is incomplete. I aim at making a new branch from this one for fixing those new problems, so that we know what was attempted and what does not work. This issue is complicated.

Running integratedtests/mayavi/test_mlab_savefig.py against master leads to the following errors on both Ubuntu 12 and OSX 10.11

OSX: 10.11, PySide 1.2.2, wxPython 3.0.2.0
Linux: Ubuntu 12, PySide 1.2.2, wxPython 2.8.10.1

Linux/OSX + qt4 + master branch

======================================================================
FAIL: test_savefig_with_size (test_mlab_savefig.TestMlabSavefigUnitTest)
Test if savefig works with given size and a normal Engine
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 108, in test_savefig_with_size
    self.check_image_size(self.filename, size=(131, 217))
  File "test_mlab_savefig.py", line 82, in check_image_size
    self.assertEqual(image.shape[:2][::-1], size)
AssertionError: Tuples differ: (128, 216) != (131, 217)

First differing element 0:
128
131

- (128, 216)
+ (131, 217)

======================================================================
FAIL: test_savefig_with_size_and_magnification (test_mlab_savefig.TestMlabSavefigUnitTest)
Test if savefig works with given size and magnification
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 124, in test_savefig_with_size_and_magnification
    self.check_image_no_black_pixel(self.filename)
  File "test_mlab_savefig.py", line 72, in check_image_no_black_pixel
    self.fail(message)
AssertionError: The image has black spots

======================================================================
FAIL: test_savefig_with_size_offscreen (test_mlab_savefig.TestMlabSavefigUnitTest)
Test savefig with given size, normal Engine and offscreen
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 156, in test_savefig_with_size_offscreen
    self.check_image_size(self.filename, size=(131, 217))
  File "test_mlab_savefig.py", line 82, in check_image_size
    self.assertEqual(image.shape[:2][::-1], size)
AssertionError: Tuples differ: (128, 216) != (131, 217)

First differing element 0:
128
131

- (128, 216)
+ (131, 217)

----------------------------------------------------------------------
Ran 7 tests in 4.762s

FAILED (failures=3)

Linux/OSX + wx + master branch

======================================================================
FAIL: test_savefig_with_size (test_mlab_savefig.TestMlabSavefigUnitTest)
Test if savefig works with given size and a normal Engine
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 108, in test_savefig_with_size
    self.check_image_size(self.filename, size=(131, 217))
  File "test_mlab_savefig.py", line 82, in check_image_size
    self.assertEqual(image.shape[:2][::-1], size)
AssertionError: Tuples differ: (540, 234) != (131, 217)

First differing element 0:
540
131

- (540, 234)
+ (131, 217)

======================================================================
FAIL: test_savefig_with_size_and_magnification (test_mlab_savefig.TestMlabSavefigUnitTest)
Test if savefig works with given size and magnification
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 123, in test_savefig_with_size_and_magnification
    self.check_image_size(self.filename, size=(262, 434))
  File "test_mlab_savefig.py", line 82, in check_image_size
    self.assertEqual(image.shape[:2][::-1], size)
AssertionError: Tuples differ: (180, 78) != (262, 434)

First differing element 0:
180
262

- (180, 78)
+ (262, 434)

======================================================================
FAIL: test_savefig_with_size_and_magnification_offscreen (test_mlab_savefig.TestMlabSavefigUnitTest)
Test savefig with given size, mag, normal Engine and offscreen
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 174, in test_savefig_with_size_and_magnification_offscreen
    self.check_image_size(self.filename, size=(262, 434))
  File "test_mlab_savefig.py", line 82, in check_image_size
    self.assertEqual(image.shape[:2][::-1], size)
AssertionError: Tuples differ: (180, 78) != (262, 434)

First differing element 0:
180
262

- (180, 78)
+ (262, 434)

======================================================================
FAIL: test_savefig_with_size_offscreen (test_mlab_savefig.TestMlabSavefigUnitTest)
Test savefig with given size, normal Engine and offscreen
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 156, in test_savefig_with_size_offscreen
    self.check_image_size(self.filename, size=(131, 217))
  File "test_mlab_savefig.py", line 82, in check_image_size
    self.assertEqual(image.shape[:2][::-1], size)
AssertionError: Tuples differ: (540, 234) != (131, 217)

First differing element 0:
540
131

- (540, 234)
+ (131, 217)

----------------------------------------------------------------------
Ran 7 tests in 9.848s

FAILED (failures=4)

On Linux + wx, I get addition errors. But they might just be because of the version of wxpython (2.8.10.1)

  File "/home/kit/.jaguar/envs/test-mayavi-2/lib/python2.7/site-packages/vtk/wx/wxVTKRenderWindowInteractor.py", line 381, in OnPaint
    self._Iren.GetRenderWindow().SetSize(self.GetSizeTuple())
AttributeError: 'NoneType' object has no attribute 'SetSize'
FTraceback (most recent call last):
  File "/home/kit/.jaguar/envs/test-mayavi-2/lib/python2.7/site-packages/vtk/wx/wxVTKRenderWindowInteractor.py", line 381, in OnPaint
    self._Iren.GetRenderWindow().SetSize(self.GetSizeTuple())
AttributeError: 'NoneType' object has no attribute 'SetSize'

The following runs integratedtests/mayavi/test_mlab_savefig.py against this branch which unveil new errors:

Linux/OSX + wx + this branch

======================================================================
FAIL: test_savefig_with_size (test_mlab_savefig.TestMlabSavefigUnitTest)
Test if savefig works with given size and a normal Engine
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 109, in test_savefig_with_size
    self.check_image_no_black_pixel(self.filename)
  File "test_mlab_savefig.py", line 72, in check_image_no_black_pixel
    self.fail(message)
AssertionError: The image has black spots

======================================================================
FAIL: test_savefig_with_size_and_magnification (test_mlab_savefig.TestMlabSavefigUnitTest)
Test if savefig works with given size and magnification
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 124, in test_savefig_with_size_and_magnification
    self.check_image_no_black_pixel(self.filename)
  File "test_mlab_savefig.py", line 72, in check_image_no_black_pixel
    self.fail(message)
AssertionError: The image has black spots

======================================================================
FAIL: test_savefig_with_size_and_magnification_offscreen (test_mlab_savefig.TestMlabSavefigUnitTest)
Test savefig with given size, mag, normal Engine and offscreen
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 174, in test_savefig_with_size_and_magnification_offscreen
    self.check_image_size(self.filename, size=(262, 434))
  File "test_mlab_savefig.py", line 82, in check_image_size
    self.assertEqual(image.shape[:2][::-1], size)
AssertionError: Tuples differ: (180, 78) != (262, 434)

First differing element 0:
180
262

- (180, 78)
+ (262, 434)

======================================================================
FAIL: test_savefig_with_size_offscreen (test_mlab_savefig.TestMlabSavefigUnitTest)
Test savefig with given size, normal Engine and offscreen
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 156, in test_savefig_with_size_offscreen
    self.check_image_size(self.filename, size=(131, 217))
  File "test_mlab_savefig.py", line 82, in check_image_size
    self.assertEqual(image.shape[:2][::-1], size)
AssertionError: Tuples differ: (90, 39) != (131, 217)

First differing element 0:
90
131

- (90, 39)
+ (131, 217)

----------------------------------------------------------------------
Ran 7 tests in 2.673s

FAILED (failures=4)

Linux/OSX + qt4 + this branch

======================================================================
FAIL: test_savefig_with_size (test_mlab_savefig.TestMlabSavefigUnitTest)
Test if savefig works with given size and a normal Engine
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 109, in test_savefig_with_size
    self.check_image_no_black_pixel(self.filename)
  File "test_mlab_savefig.py", line 72, in check_image_no_black_pixel
    self.fail(message)
AssertionError: The image has black spots

======================================================================
FAIL: test_savefig_with_size_and_magnification (test_mlab_savefig.TestMlabSavefigUnitTest)
Test if savefig works with given size and magnification
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_mlab_savefig.py", line 124, in test_savefig_with_size_and_magnification
    self.check_image_no_black_pixel(self.filename)
  File "test_mlab_savefig.py", line 72, in check_image_no_black_pixel
    self.fail(message)
AssertionError: The image has black spots

----------------------------------------------------------------------
Ran 7 tests in 2.275s

FAILED (failures=2)

default magnification would be 1 warn about magnification="auto" and floats

…result

…om/enthought/mayavi into fix-savefig-size-auto-magnification

kitchoi · 2016-10-05T14:42:24Z

too stale, closing.

kitchoi added 7 commits April 21, 2016 10:18

savefig size and magnification are used as given.

4020794

default magnification would be 1 warn about magnification="auto" and floats

resizing wx window on idle is done once only

37315ab

added test for mlab.savefig with size and magnification

b5284e5

add tests with offscreen rendering

a91f8ef

exit code 1 for integrationtests required for run.py to register the …

b33edcc

…result

skip offscreen rendering tests on travis

eaf6f8d

Merge branch 'fix-savefig-size-auto-magnification' of http://github.c…

cf1ee91

…om/enthought/mayavi into fix-savefig-size-auto-magnification

kitchoi changed the title ~~Reimplement fix savefig with size and magnification~~ Reimplement fix savefig with size and magnification [WIP] Apr 21, 2016

This was referenced Apr 21, 2016

Reimplement fix savefig size and black image - step 1 [WIP] #347

Closed

Fix savefig size and black image #331

Merged

Reimplement fix savefig size and black image - step 2 (last) #350

Closed

kitchoi changed the title ~~Reimplement fix savefig with size and magnification [WIP]~~ Reimplement fix savefig with size and magnification - step 0 [WIP] Jun 2, 2016

itziakos mentioned this pull request Jun 13, 2016

[WIP] Run integration tests on qt #390

Closed

kitchoi closed this Oct 5, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reimplement fix savefig with size and magnification - step 0 [WIP] #346

Reimplement fix savefig with size and magnification - step 0 [WIP] #346

kitchoi commented Apr 21, 2016

kitchoi commented Oct 5, 2016

Reimplement fix savefig with size and magnification - step 0 [WIP] #346

Reimplement fix savefig with size and magnification - step 0 [WIP] #346

Conversation

kitchoi commented Apr 21, 2016

kitchoi commented Oct 5, 2016