Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Support Python 3.9 #983

Merged
merged 1 commit into from
Dec 10, 2020
Merged

MAINT: Support Python 3.9 #983

merged 1 commit into from
Dec 10, 2020

Conversation

larsoner
Copy link
Collaborator

base64.decodestring does not exist in Python 3.9 so current master causes an error on import. decodestring has been deprecated since 3.1 so should be safe just to use decodebytes directly (and same with encodebytes).

@codecov-io
Copy link

codecov-io commented Dec 10, 2020

Codecov Report

Merging #983 (c0be6ef) into master (8780225) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #983   +/-   ##
=======================================
  Coverage   49.79%   49.79%           
=======================================
  Files         263      263           
  Lines       23927    23927           
  Branches     3259     3259           
=======================================
  Hits        11914    11914           
  Misses      11236    11236           
  Partials      777      777           
Impacted Files Coverage Δ
mayavi/tools/remote/ipy_remote.py 0.00% <0.00%> (ø)
mayavi/tools/remote/remote_scene.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8780225...013c40f. Read the comment docs.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simply remove the temporary variables now and just use base64.decodebytes or base64.encodebytes. Can you please make that change?

@larsoner
Copy link
Collaborator Author

@rahulporuri done

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @larsoner ! Waiting for CI.

@rahulporuri rahulporuri merged commit 61ef7c0 into enthought:master Dec 10, 2020
@larsoner larsoner deleted the 3.9 branch December 10, 2020 15:59
@prabhuramachandran
Copy link
Member

@larsoner -- thanks! @rahulporuri -- thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants