-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Support Python 3.9 #983
Conversation
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
=======================================
Coverage 49.79% 49.79%
=======================================
Files 263 263
Lines 23927 23927
Branches 3259 3259
=======================================
Hits 11914 11914
Misses 11236 11236
Partials 777 777
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simply remove the temporary variables now and just use base64.decodebytes
or base64.encodebytes
. Can you please make that change?
@rahulporuri done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @larsoner ! Waiting for CI.
@larsoner -- thanks! @rahulporuri -- thanks for merging. |
base64.decodestring
does not exist in Python 3.9 so currentmaster
causes an error on import.decodestring
has been deprecated since 3.1 so should be safe just to usedecodebytes
directly (and same withencodebytes
).