Don't raise ConditionTimeoutError if event loop does not time out
#1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see any way to test the condition never evaluated branches.
|
Thanks |
corranwebster
deleted the
fix/event-loop-until-condition-warn-no-timeout
branch
corranwebster
added
the
needs backport to maint/*
corranwebster
added a commit
that referenced
this pull request
Nov 21, 2022
…1182) * Don't raise ConditionTimeoutError if event loop does not time out. * Can't reliably ensure event loop finishes before call to condition. I don't see any way to test the condition never evaluated branches.
corranwebster
added a commit
that referenced
this pull request
Nov 21, 2022
…1182) * Don't raise ConditionTimeoutError if event loop does not time out. * Can't reliably ensure event loop finishes before call to condition. I don't see any way to test the condition never evaluated branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1181.
Also checks whether the condition was ever called and gives different messages depending on the cases.