fix: add deprecated QStyleOption names in the Qt5 interfaces #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a crash in Mayavi when using pyface 6.0 and PyQt 5.6.
The crash can be reproduced by trying to drag the Tab labeled "Mayavi Scene 1" in the screen shot below:
Trying to drag the tab crashes the application with the following traceback.
The names QStyleOptionTabV3, QStyleOptionTabV2 and QStyleOptionTabBarBaseV2 have been deprecated and do not exist in the PyQt5 or PySide2 namespaces. This PR adds them to the pyface.qt.QtGui namespace. Relevant Qt documentation:
https://doc.qt.io/qt-5.10/qstyleoptiontab-obsolete.html
https://doc.qt.io/qt-5/qstyleoptiontabbarbase-obsolete.html