Base Application Class #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aim to keep application as simple as possible.
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 24.71% 24.97% +0.25%
==========================================
Files 455 456 +1
Lines 25568 25658 +90
Branches 3855 3860 +5
==========================================
+ Hits 6319 6407 +88
- Misses 18938 18939 +1
- Partials 311 312 +1
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to get the application classes landed in the codebase by working incrementally, given that #198 and #285 are stalled.
This is a base application class taken from #198 and simplified slightly.