Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-work of TasksApplication on top of other Application PRs #345

Merged
merged 8 commits into from
Dec 18, 2018

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Nov 13, 2018

This is re-work of #198 and #285 on top of #335

Needs:

  • examples
  • CI running correctly

@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #345 into master will increase coverage by 0.45%.
The diff coverage is 67.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   34.42%   34.88%   +0.45%     
==========================================
  Files         457      462       +5     
  Lines       25432    25656     +224     
  Branches     3797     3823      +26     
==========================================
+ Hits         8754     8949     +195     
- Misses      16308    16329      +21     
- Partials      370      378       +8
Impacted Files Coverage Δ
pyface/tasks/action/listening_action.py 0% <0%> (-25.38%) ⬇️
pyface/tasks/action/task_toggle_group.py 48.97% <0%> (+0.97%) ⬆️
pyface/ui/qt4/window.py 73.87% <0%> (-0.68%) ⬇️
pyface/tasks/traits_editor.py 47.05% <0%> (-2.95%) ⬇️
pyface/action/api.py 100% <100%> (ø) ⬆️
pyface/api.py 100% <100%> (ø) ⬆️
pyface/tasks/api.py 100% <100%> (ø) ⬆️
pyface/tasks/action/task_action.py 60% <100%> (ø) ⬆️
pyface/tasks/action/api.py 100% <100%> (ø) ⬆️
pyface/ui/qt4/about_dialog.py 79.41% <28.57%> (-8.09%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ce970...020eb76. Read the comment docs.

@corranwebster corranwebster changed the title [WIP] Re-work of TasksApplication on top of other Application PRs Re-work of TasksApplication on top of other Application PRs Nov 29, 2018
@corranwebster
Copy link
Contributor Author

@jonathanrocher If you would like to review this, I'd appreciate it.

@corranwebster
Copy link
Contributor Author

At this point I am going to self-merge this. The PR was meant to unify approaches that @jonathanrocher and I had for Envisage-compatible application classes. It can be refined as time goes on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants