-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of 2to3 with six #355
Conversation
- use of `...` instead of '...' - defining a tuple in the function definition modified: pyface/tree/node_tree.py modified: pyface/wx/shell.py
and replace with the equivalent use of collections.abc.Sequence
modified: pyface/action/group.py modified: pyface/util/fix_introspect_bug.py
i.e. keys, values, items/iteritems
modified: pyface/i_window.py modified: pyface/tasks/traits_task_pane.py modified: pyface/ui/wx/tasks/dock_pane.py modified: pyface/ui/wx/tasks/editor_area_pane.py modified: pyface/tasks/action/task_action_manager_builder.py
modified: setup.py
which got added by mistake. should have added the .bak files to the gitignore list
modified: pyface/i_window.py
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 35.12% 35.17% +0.04%
==========================================
Files 463 463
Lines 25732 25769 +37
Branches 3831 3830 -1
==========================================
+ Hits 9039 9063 +24
- Misses 16311 16324 +13
Partials 382 382
Continue to review full report at Codecov.
|
That was surprising. There was a broken import which got fixed in the commit ac76443 which has surprisingly fixed the test failures. Not sure why though.
|
For now, the Sequence import should be collections.Sequence, which might need to change in future versions of Python modified: pyface/resource/resource_manager.py
Thanks for doing this - it has been on my to-do list for a while but have not gotten around to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of glitches in print
statements, but otherwise looks good to me.
- remove unnecessary parenthesis in print function call - cleanup creation of set modified: pyface/timer/tests/test_timer.py modified: pyface/ui/qt4/console/console_widget.py
instead of passing the elements of the list, which is obviously wrong modified: pyface/ui/qt4/console/console_widget.py
modernize
was used to make the necessary changes.The changes introduced in this PR are :
xrange
basestring
andunicode
exception
statementraise
statementprint
statementcStringIO
,thread
andcPickle
has_key
,values
,keys
,items
func_name