Add support for widgets in toolbars #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 35.16% 35.19% +0.02%
==========================================
Files 463 463
Lines 25772 25799 +27
Branches 3830 3834 +4
==========================================
+ Hits 9064 9079 +15
- Misses 16326 16336 +10
- Partials 382 384 +2
Continue to review full report at Codecov.
|
jwiggins
reviewed
Mar 8, 2019
| @@ -245,6 +263,9 @@ class _Tool(HasTraits): | |||
| # The toolkit control. | |||
| control = Any() | |||
|
|
|||
| # The toolkit control id. | |||
| control_id = None | |||
There was a problem hiding this comment.
Is this not purely a Wx-ism as stated in the previous comment?
There was a problem hiding this comment.
Yep - I'd like to get rid of it, but it was already implicitly there. This is drive-by clean-up to make it explicit (then we can work out how to get rid of it in a separate PR at a later time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper Pyface-level support for
Actions which contain widgets. Support is very basic, but works.