Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow traits UI-based dispatch even when TraitsUI not available #363

Merged
merged 1 commit into from
Apr 21, 2019

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Apr 21, 2019

This checks to see if there is a ui dispatcher available for Traits when initializing the Pyface toolkit, and if not sets one.

This PR also includes a change that makes _FutureCall behave more like the TraitsUI _CallAfter for the qt toolkit when there is no delay for the callback. This will potentially allow _CallAfter to be removed from TraitsUI in the future.

Fixes #362

@codecov-io
Copy link

codecov-io commented Apr 21, 2019

Codecov Report

Merging #363 into master will increase coverage by 0.02%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage    35.2%   35.22%   +0.02%     
==========================================
  Files         463      463              
  Lines       25807    25820      +13     
  Branches     3835     3838       +3     
==========================================
+ Hits         9085     9096      +11     
  Misses      16338    16338              
- Partials      384      386       +2
Impacted Files Coverage Δ
pyface/ui/qt4/gui.py 86.51% <100%> (+0.8%) ⬆️
pyface/ui/wx/init.py 71.42% <75%> (+1.42%) ⬆️
pyface/ui/qt4/init.py 62.5% <75%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6d11d...d0729ba. Read the comment docs.

@corranwebster corranwebster merged commit 966cca9 into master Apr 21, 2019
@corranwebster corranwebster deleted the enh/ui-dispatch-with-no-traitsui branch April 21, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traits UI-based dispatch is set up in TraitsUI, not Pyface
2 participants