Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TraitsUI dependency of GuiTestAssistant #366

Merged
merged 3 commits into from
Apr 25, 2019

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Apr 23, 2019

Checks to see if traitsui is available before patching StickyDialog.

Fixes #341 and fixes #353.

@corranwebster
Copy link
Contributor Author

Hmmm... makes sense to fold in a fix to #353 into this PR as well.

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #366 into master will increase coverage by 1.17%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   35.15%   36.32%   +1.17%     
==========================================
  Files         463      481      +18     
  Lines       25820    26406     +586     
  Branches     3838     3911      +73     
==========================================
+ Hits         9076     9591     +515     
- Misses      16350    16401      +51     
- Partials      394      414      +20
Impacted Files Coverage Δ
pyface/ui/qt4/util/gui_test_assistant.py 80.18% <75%> (+1.53%) ⬆️
pyface/action/api.py 100% <0%> (ø) ⬆️
pyface/timer/api.py 100% <0%> (ø) ⬆️
pyface/ui/wx/fields/combo_field.py 75.47% <0%> (ø)
pyface/ui/wx/fields/field.py 81.81% <0%> (ø)
pyface/ui/qt4/fields/combo_field.py 79.24% <0%> (ø)
pyface/action/traitsui_widget_action.py 100% <0%> (ø)
pyface/ui/wx/fields/text_field.py 81.39% <0%> (ø)
pyface/fields/combo_field.py 100% <0%> (ø)
pyface/ui/qt4/fields/spin_field.py 100% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966cca9...d1c19c3. Read the comment docs.

Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit a60e7bf into master Apr 25, 2019
@corranwebster corranwebster deleted the fix/guitestassistant-traitsui-requirement branch April 25, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use mock from unittest in Python 3 GuiTestAssistant requires TraitsUI
3 participants