Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing tests on text field #368

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Conversation

corranwebster
Copy link
Contributor

Forgot tests for a couple of attributes.

@jwiggins
Copy link
Member

This is good? The tests you added failed. TDD!

@corranwebster
Copy link
Contributor Author

The code was written on a computer where I couldn't easily do testing (didn't particularly want to install EDM on it). But it is good that it failed, as it looks like there may be an actual bug or two.

@corranwebster
Copy link
Contributor Author

Test cases hopefully now working on all platforms. This is why we write tests.

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #368 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   36.31%   36.33%   +0.02%     
==========================================
  Files         481      481              
  Lines       26398    26398              
  Branches     3909     3909              
==========================================
+ Hits         9586     9592       +6     
+ Misses      16399    16391       -8     
- Partials      413      415       +2
Impacted Files Coverage Δ
pyface/fields/i_text_field.py 73.91% <100%> (+2.89%) ⬆️
pyface/ui/wx/fields/text_field.py 86.04% <100%> (+4.65%) ⬆️
pyface/ui/qt4/fields/text_field.py 88.09% <100%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8b024...89dcdaf. Read the comment docs.

Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once the print is gone

@corranwebster corranwebster merged commit 02f829c into master Apr 24, 2019
@corranwebster corranwebster deleted the enh/fields-missing-tests branch April 24, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants