-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some missing tests on text field #368
Conversation
This is good? The tests you added failed. TDD! |
The code was written on a computer where I couldn't easily do testing (didn't particularly want to install EDM on it). But it is good that it failed, as it looks like there may be an actual bug or two. |
Test cases hopefully now working on all platforms. This is why we write tests. |
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 36.31% 36.33% +0.02%
==========================================
Files 481 481
Lines 26398 26398
Branches 3909 3909
==========================================
+ Hits 9586 9592 +6
+ Misses 16399 16391 -8
- Partials 413 415 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 once the print
is gone
Forgot tests for a couple of attributes.