Ensure we set Qt API versions for PyQt4 before importing QtCore #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 36.35% 36.33% -0.03%
==========================================
Files 481 481
Lines 26420 26424 +4
Branches 3915 3917 +2
==========================================
- Hits 9604 9600 -4
- Misses 16398 16404 +6
- Partials 418 420 +2
Continue to review full report at Codecov.
|
mdickinson
reviewed
May 3, 2019
etstool.py
Outdated
| @@ -179,7 +179,8 @@ def install(runtime, toolkit, environment): | |||
| @click.option('--runtime', default='3.6') | |||
| @click.option('--toolkit', default='pyqt') | |||
| @click.option('--environment', default=None) | |||
| def test(runtime, toolkit, environment): | |||
| @click.option('--no-environment-vars', is_flag=True) | |||
There was a problem hiding this comment.
Worth adding some help for this option?
mdickinson
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374