Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for PySide #861

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Conversation

corranwebster
Copy link
Contributor

This does part but not all of #510 - this removes support for PySide, but not PyQt4.

Traits no longer supports any version of Python compatible with the original PySide, so this has been dead code for a while.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM but I have a couple of orthogonal questions.

Traits no longer supports any version of Python compatible with the original PySide, so this has been dead code for a while.

I'm not entirely sure what you mean by this. It looks like PySide officially supported Python <= 3.4 (https://pypi.org/project/PySide/#files) but I suspect we can still use PySide on Python 3.6.

Also, do we want this merged before Pyface 7.2.0? We are already planning to drop support for Traits < 6.2.0 in the upcoming Pyface release. The next pyface release is planned for early-to-mid February.

pyface/qt/QtScript.py Outdated Show resolved Hide resolved
@rahulporuri rahulporuri added this to In progress in Enthought OSS Q1 2021 Jan 19, 2021
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
@corranwebster
Copy link
Contributor Author

I'm not entirely sure what you mean by this. It looks like PySide officially supported Python <= 3.4 (https://pypi.org/project/PySide/#files) but I suspect we can still use PySide on Python 3.6.

The last version of Python that can be used with the original PySide is Python 3.4. PySide2 is the version for compatibility with Python >= 3.5 - there is no way to get original PySide on Python 3.6+

@corranwebster
Copy link
Contributor Author

Also, do we want this merged before Pyface 7.2.0?

It should probably be in the next release, yes.

@corranwebster corranwebster merged commit 9419755 into master Jan 19, 2021
Enthought OSS Q1 2021 automation moved this from In progress to Done Jan 19, 2021
@corranwebster corranwebster deleted the enh/qt4-remove-pyside-support branch January 19, 2021 12:59
@rahulporuri rahulporuri moved this from Done to Sprint 1 : Jan 4 2021 - Jan 22 2021 in Enthought OSS Q1 2021 Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q1 2021
Sprint 1 : Jan 4 2021 - Jan 22 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants