Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup slack notification for cron job #983

Merged
merged 1 commit into from Jul 14, 2021

Conversation

rahulporuri
Copy link
Contributor

This PR sets up the slack notification for the cron job.

I manually triggered the cron job to check that the slack notification gets fired. Ref https://github.com/enthought/pyface/actions/runs/1027257422.

One more step towards enthought/ets#65

	modified:   .github/workflows/ets-from-source.yml
@aaronayres35 aaronayres35 self-requested a review July 13, 2021 17:27
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not sure what happened on the run though - failure was reported to slack but logs on workflow aren't there

I see: "GitHub Actions has encountered an internal error when running your job."

I think some of the failures might be just from having so many jobs running on GH actions at once across all ets repos

@rahulporuri
Copy link
Contributor Author

I think some of the failures might be just from having so many jobs running on GH actions at once across all ets repos

You're probably right 😅 There were definitely one too many jobs running yesterday. For now, i'll go ahead and merge this - and revisit this if things don't work as expected over the weekend.

@rahulporuri rahulporuri merged commit 4d6a2f3 into master Jul 14, 2021
@rahulporuri rahulporuri deleted the dev/cron-job-slack-notifications branch July 14, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants