Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 21 #22

Closed
wants to merge 35 commits into from
Closed

Fix issue 21 #22

wants to merge 35 commits into from

Conversation

itziakos
Copy link
Member

fixes #22

@itziakos
Copy link
Member Author

@cournape, This PR is ready for review.

The problem was that the callback functions receive the resource type and resource name as a pointer to wchar. But the value of the pointer passes the IS_INTRESOURCE check that it is interprated as an integer index inastead of a string (see https://msdn.microsoft.com/en-us/library/windows/desktop/ms648041%28v=vs.85%29.aspx)

The solutiuon is to claim the input types are LPVOID and wrap the user provided callback in order to convert them into python frieadly types. This results in similar output with the origin win32api library.

The error was not visible before because the python.exedoes not have resource types defined by name. I have use alternative files that should exist on all windows platforms.

The tests pass locally and if #24 is merged then we can also check that they pass on Travis-CI

@itziakos
Copy link
Member Author

I merged #24 into this PR so that I can run the tests on travis-ci

@itziakos
Copy link
Member Author

closing to make PR against #24 so that it is easier to review

@itziakos itziakos closed this Apr 11, 2015
@itziakos itziakos deleted the fix-issue-21 branch May 18, 2015 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant