New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 21 #25
Closed
Closed
Fix issue 21 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are not pickedup by mistake
Closed
closing to make against current master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #21
The problem was that the callback functions receive the resource type and resource name as a pointer to wchar. But the value of the pointer passes the
IS_INTRESOURCE
check that it is interprated as an integer index inastead of a string (see https://msdn.microsoft.com/en-us/library/windows/desktop/ms648041%28v=vs.85%29.aspx)The solutiuon is to claim the input types are LPVOID and wrap the user provided callback in order to convert them into python frieadly types. This results in similar output with the origin win32api library.
The error was not visible before because the
python.exe
does not have resource types defined by name. I have use alternative files that should exist on all windows platforms.