Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3 errors #52

Merged
merged 3 commits into from
May 5, 2017
Merged

Fix python 3 errors #52

merged 3 commits into from
May 5, 2017

Conversation

itziakos
Copy link
Member

@itziakos itziakos commented May 4, 2017

Make sure that the pythonapi functions have the right signature and cast the input values to the right types

fixes issue #51

@codecov-io
Copy link

codecov-io commented May 4, 2017

Codecov Report

Merging #52 into master will increase coverage by 0.31%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   88.08%   88.39%   +0.31%     
==========================================
  Files          38       38              
  Lines        1007     1017      +10     
  Branches       92       94       +2     
==========================================
+ Hits          887      899      +12     
+ Misses         83       81       -2     
  Partials       37       37
Impacted Files Coverage Δ
win32ctypes/core/ctypes/_common.py 86.36% <100%> (+2.15%) ⬆️
win32ctypes/core/ctypes/_advapi32.py 89.79% <100%> (ø) ⬆️
win32ctypes/pywin32/win32api.py 87.5% <71.42%> (+0.4%) ⬆️
build/lib/win32ctypes/core/ctypes/_advapi32.py 83.33% <0%> (ø) ⬆️
build/lib/win32ctypes/pywin32/win32api.py 87.3% <0%> (+0.41%) ⬆️
build/lib/win32ctypes/core/ctypes/_common.py 85.71% <0%> (+13.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f33db...3a5c781. Read the comment docs.

@itziakos itziakos requested a review from cournape May 4, 2017 00:28
@itziakos itziakos added this to the 0.1.0 milestone May 4, 2017
@itziakos itziakos merged commit 2ffdf1f into master May 5, 2017
@itziakos itziakos deleted the fix-python-3-errors branch May 5, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants