Fix UpdateResource function + tests

[virtuald]

Thanks!

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (prepare-0.1.0-release@2f4d71f). Click here to learn what that means.
The diff coverage is 100%.

@@                   Coverage Diff                    @@
##             prepare-0.1.0-release      #57   +/-   ##
========================================================
  Coverage                         ?   90.77%           
========================================================
  Files                            ?       38           
  Lines                            ?     1019           
  Branches                         ?       94           
========================================================
  Hits                             ?      925           
  Misses                           ?       57           
  Partials                         ?       37

Impacted Files	Coverage Δ
win32ctypes/core/ctypes/_kernel32.py	100% <ø> (ø)
win32ctypes/core/cffi/_kernel32.py	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4d71f...6357e13. Read the comment docs.

[itziakos]

A minor change. I think I will add a check_true so that a bool is returned in such cases

[itziakos]

This assertion should probably be moved to the test_begin_and_end_update_resource

[virtuald]

You're right, it should be added -- but this test would be equally invalid if that call failed, so it should be here also.

[itziakos]

good point

[virtuald]

28/631 pyinstaller tests fail, so there must be another API incompatibility lurking somewhere (unless it's an msys specific thing). Will look some more this weekend.

[itziakos]

No problem, I want to investigate something myself. I think there is an issue with UpdateResource and the data passed to the resource. The pData needs to point to a continues array of bytes and the cdData is calculated in bytes. If I am right we need to make sure that we pass the right info depending on the input data object.