Implement dispose for wx simple TextEditor (base class) #1161
Conversation
| tester = UITester([LOCAL_TARGET_REGISTRY]) | ||
| with tester.create_ui(ObjectWithFont(), dict(view=view)) as ui: | ||
| wrapper = tester.find_by_name(ui, "font_trait") | ||
| wrapper.perform(command.MouseClick()) |
There was a problem hiding this comment.
For the record, I was able to get the attribute error shown in #942, but for some reasons the event is processed so late that the error occurrs after the context manager exits. Hence it is not captured for causing the test to fail. The error was printed to the console however. I did not try to dive any further into understanding why the exception could not be captured. The fix resolves issue such that the error is not printed to the console.
There was a problem hiding this comment.
FWIW I observed the same
|
Updated to test the font editor for Qt as well. It is strictly speaking orthogonal to fixing #942, but is a good opportunity to expand test coverage and UITester support. |
| @@ -116,6 +116,17 @@ def init(self, parent): | |||
| parent.Bind(wx.EVT_TEXT_ENTER, self.update_object, id=self.control.GetId()) | |||
| self.set_tooltip() | |||
|
|
|||
| def dispose(self): | |||
There was a problem hiding this comment.
could we add a docstring here?
Closes #942
Also resolve the second item in #1073
Also part of #752
The cause of the issue is as explained in #942. This base class is used by both the text style FontEditor and the text style CompoundEditor.
I came across this while I was trying to resolve #1145.
(The solution I am going to propose for #1145 also "resolves the error" in the context when the UI wrapping this editor has its
disposemethod called. But I believe removing the handler hooks with Unbind is still the right thing to do.)As a drive-by improvement to the test coverage, implementations are added for testing the Qt implementation of the same editor.