Open links externally instead of in the html editor in etsdemo application #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of in the editor modified: ets-demo/etsdemo/app.py
|
My bad I did not manually test this with my usual PySide2-from-PyPI exercise. |
This was referenced Dec 16, 2020
rahulporuri
moved this from Done
to Sprint 6 : Dec 14 2020 - Jan 2 2021
in Enthought OSS Q4 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the etsdemo application such that clicking on links in the description will be opened in the default browser instead of in the html editor itself. This behavior was observed in #1445 and was recommended as the right user experience - #1445 (comment)