Hide demo tab when the demo is None #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronayres35
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
LGTM! (although code is a little clunky from tabs not working with visible_when but thats orthogonal)
I tested with the envisage examples that don't have a demo GUI component and everything looked correct (and I verified things still look the same when there is a demo GUI).
yoda-vid
added a commit
to stephansanders/citation-overlap
that referenced
this pull request
May 17, 2021
Expand the number of imported citations lists per session to 5 by incorporating two dynamically added import views and associated sheets. As TraitsUI does not appear to support dynamic tab addition currently (see enthought/traitsui#1456), create separate views, each with an additional tab, toggled based on a Trait. Add a button next to the extractor add button to add each tab, which becomes disabled after adding two new tabs/sheets. Add back a default extractor, this time a prompt for the user to select an extractor.
yoda-vid
added a commit
to stephansanders/citation-overlap
that referenced
this pull request
May 18, 2021
Expand the number of imported citations lists per session to 5 by incorporating two dynamically added import views and associated sheets. As TraitsUI does not appear to support dynamic tab addition currently (see enthought/traitsui#1456), create separate views, each with an additional tab, toggled based on a Trait. Add a button next to the extractor add button to add each tab, which becomes disabled after adding two new tabs/sheets. Add back a default extractor, this time a prompt for the user to select an extractor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an alternative group in demo file view for when demo is None.
Unfortunately we can't just hide the "Demo" tab, because dynamic hiding doesn't work.
This should essentially fix #1454