Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Update copyright headers in traitsui #1467

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Jan 6, 2021

The recommended source code header policy at the moment is the following -

# (C) Copyright 2004-2021 Enthought, Inc., Austin, TX
# All rights reserved.
#
# This software is provided without warranty under the terms of the BSD
# license included in LICENSE.txt and may be redistributed only under
# the conditions described in the aforementioned license. The license
# is also available online at http://www.enthought.com/licenses/BSD.txt
#
# Thanks for using Enthought open source!

This PR updates the copyright headers for all source code in the traitsui package and in the integrationtests directory. Note that copyright has been updated to start from 2004. This is because I noticed a number of source code modules were written by David C Morill in 2004.

For lack of a better way, this was all done manually. Each source code module in the codebase was manually opened and the copyright header was checked/updated.

NOTE: There are number of modules which are Riverbank Copyright headers. For those modules, there exist now two headers - the original header with the Riverbank Copyright and the new Enthought header.

Note that this PR does not update the source code headers in the etsdemo distribution. That will be done in a separate PR. Additionally, flake8 has not been setup at the moment - which will be done in a separate PR.

The copyright headers were in some cases in the wrong format and in
other cases, they headers were outdated.

This commit fixes and updates the copyright headers in all of traitsui
and the integrationtests for traitsui
@aaronayres35
Copy link
Contributor

The header in the PR description does not match the changes made in the PR. Could we update the PR description?

@rahulporuri rahulporuri changed the title Fix/Update copyright headers Fix/Update copyright headers in traitsui Jan 6, 2021
@rahulporuri
Copy link
Contributor Author

The header in the PR description does not match the changes made in the PR. Could we update the PR description?

I'm not entirely sure what the mismatch is. Can you elaborate?

The PR fixes/updates the copyright headers in the codebase.

@rahulporuri rahulporuri added this to In progress in Enthought OSS Q1 2021 Jan 6, 2021
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

integrationtests/ui/code_editor_test.py Show resolved Hide resolved
@@ -1,3 +1,13 @@
# (C) Copyright 2008-2021 Enthought, Inc., Austin, TX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming it was intentional that many of these are left as 2008-2021 not 2004-2021?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was intentional. I updated the PR description to reflect this - some of the source code in traitsui has Riverbank Copyright headers. We should not remove those headers - and we can claim copyright to those source code modules from the year after which Riverbank copyright.

@rahulporuri rahulporuri merged commit bffbb3b into master Jan 6, 2021
Enthought OSS Q1 2021 automation moved this from In progress to Done Jan 6, 2021
@rahulporuri rahulporuri deleted the dev/update-copyright-headers branch January 6, 2021 14:19
@rahulporuri rahulporuri moved this from Done to Sprint 1 : Jan 4 2021 - Jan 22 2021 in Enthought OSS Q1 2021 Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q1 2021
Sprint 1 : Jan 4 2021 - Jan 22 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants