Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link for installing wxPython on CI (for etsdemo) #1491

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Jan 20, 2021

Currently Travis CI setup install etsdemo for the wx toolkit (because it is otherwise hard to break it out in a single config file), but the install step fails at the point of installing wxPython. We still expect tests to fail/error for the wx toolkit for the etsdemo application though.

This is a quick fix to get CI to at least run the tests. We need a better solution to replace this hardcoded ubuntu version in the install command.

(Note that this PR is independent of TraitsUI, but the CI between TraitsUI and etsdemo are tied.)

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We're not using etsdemo in GitHub Actions so we don't need to worry about that (because travis uses 16.04 by default and github actions uses 18.04 IIUC)

@rahulporuri rahulporuri added this to In progress in Enthought OSS Q1 2021 Jan 20, 2021
@kitchoi kitchoi merged commit 04e4d1c into master Jan 20, 2021
Enthought OSS Q1 2021 automation moved this from In progress to Done Jan 20, 2021
@kitchoi kitchoi deleted the fix-ci-linux-setup branch January 20, 2021 11:24
@rahulporuri rahulporuri moved this from Done to Sprint 1 : Jan 4 2021 - Jan 22 2021 in Enthought OSS Q1 2021 Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q1 2021
Sprint 1 : Jan 4 2021 - Jan 22 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants