Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance choice classes to traitsui.api #1495

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

aaronayres35
Copy link
Contributor

closes #1494

This PR simply adds instance choice related classes to the traitsui.api

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

traitsui/api.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. Can you check if there are any new sphinx warnings generated because of these changes when the documentation is built?

@aaronayres35
Copy link
Contributor Author

Still LGTM. Can you check if there are any new sphinx warnings generated because of these changes when the documentation is built?

Just checked and I'm not seeing any new warnings from these changes

@aaronayres35 aaronayres35 merged commit 79b66f5 into master Jan 25, 2021
@aaronayres35 aaronayres35 deleted the add-instancechoice-api branch January 25, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InstanceChoice, InstanceChoiceItem, and InstanceFactory should be added to traitsui.api
2 participants