Replace use of depends_on in Traits Properties with observe #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the use of depends_on metadata on properties with the use of observe metadata.
modified: traitsui/ui.py
There was a problem hiding this comment.
Mostly LGTM, but a couple suggested changes. Most notably in traitsui/ui.py for the use of trait on the extended trait name "view._key_bindings"
I apologize for the non-unified review. I inadvertently clicked "add single comment", and also "comment" rather than "request changes"
modified: examples/tutorials/traitsui_4.0/items.py modified: traitsui/ui.py
rahulporuri
moved this from Done
to Sprint 4 : March 1 - March 12 2021
in Enthought OSS Q1 2021
rahulporuri
moved this from Sprint 4 : March 1 - March 12 2021
to Sprint 3 : Feb 8 2021 - Feb 26 2021
in Enthought OSS Q1 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of
depends_onmetadata on Traits Properties with the use ofobservemetadata. Contributes towards #1052