Dynamic otc to observe 2 #1525
Merged
Dynamic otc to observe 2 #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronayres35
commented
Feb 23, 2021
|
Ah I realize my hacky fix was dumb... |
rahulporuri
approved these changes
Feb 24, 2021
| @@ -201,7 +201,7 @@ def init(self, ui, parent, style): | |||
| self.control.accept, | |||
| default=default, | |||
| ) | |||
| ui.on_trait_change(self._on_error, "errors", dispatch="ui") | |||
| ui.observe(self._on_error, "errors", dispatch="ui") | |||
There was a problem hiding this comment.
We don't seem to be unhooking this listener.
| @@ -155,7 +155,7 @@ def init(self, ui, parent, style): | |||
| self.control.accept, | |||
| default=default, | |||
| ) | |||
| ui.on_trait_change(self._on_error, "errors", dispatch="ui") | |||
| ui.observe(self._on_error, "errors", dispatch="ui") | |||
There was a problem hiding this comment.
Looks like we have two listeners that don't get unhooked in this module. Instead of going over your PRs again and creating an issue pointing out unhooked listeners like we did in Pyface, let's create an issue in traitsui now - which we can continually update?
There was a problem hiding this comment.
I've opened #1526
rahulporuri
moved this from Done
to Sprint 3 : Feb 8 2021 - Feb 26 2021
in Enthought OSS Q1 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #1052
This PR updates a few files to use dynamic
observeinstead ofon_trait_change. More similar PRs to follow