Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartStyling API changed for new Wx version #1536

Merged
merged 1 commit into from
Mar 12, 2021
Merged

StartStyling API changed for new Wx version #1536

merged 1 commit into from
Mar 12, 2021

Conversation

rahulporuri
Copy link
Contributor

	modified:   traitsui/wx/code_editor.py
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when I ran kiva explorer on. wx devenv on master I did not see the relevant part of the traceback... only the other pyface errors.

Nonetheless the traceback for the error you reported, the wx docs, and the changes made in this PR all make sense so LGTM.

I guess the old mask argument is no longer necessary? https://pythonhosted.org/wxPython/wx.stc.StyledTextCtrl.html#wx.stc.StyledTextCtrl.StartStyling

@rahulporuri
Copy link
Contributor Author

I guess the old mask argument is no longer necessary? https://pythonhosted.org/wxPython/wx.stc.StyledTextCtrl.html#wx.stc.StyledTextCtrl.StartStyling

From the sound of it, yeah. I'm just blindly going by what the documented API says I should be doing - apart from that I don't know enough wx.

@rahulporuri
Copy link
Contributor Author

LGTM, when I ran kiva explorer on. wx devenv on master I did not see the relevant part of the traceback... only the other pyface errors.

This error was the very first error that I see reported on the commandline - all of the pyface errors are reported after this issue.

@rahulporuri rahulporuri merged commit 2b01eae into master Mar 12, 2021
@rahulporuri rahulporuri deleted the fix/1535 branch March 12, 2021 15:16
@aaronayres35
Copy link
Contributor

LGTM, when I ran kiva explorer on. wx devenv on master I did not see the relevant part of the traceback... only the other pyface errors.

This error was the very first error that I see reported on the commandline - all of the pyface errors are reported after this issue.

First error in the command line for me was pyface error. I imagine my traceback was just truncated though? In any case, the code was clearly broken given new wx api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeEditor error when using kiva explorer with wx backend
2 participants