Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import "TraitFactory" from "traits.api" #1606

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

rahulporuri
Copy link
Contributor

This PR makes a very trivial/simple change - it imports TraitFactory from traits.api instead of traits.trait_factory. This was fixed in traits in enthought/traits#730 and has been available in traits since v 6.0.0.

@rahulporuri rahulporuri added this to In progress in Enthought OSS Q2 2021 Apr 26, 2021
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri
Copy link
Contributor Author

I think we have seen this failure before. Restarted CI job because AFAIK this is an intermittent failure.

======================================================================
FAIL: test_qt_process_events_process_all (traitsui.testing.tests.test_gui.TestProcessEventsRepeated)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\traitsui\traitsui\.edm\envs\traitsui-test-3.6-pyqt\lib\site-packages\traitsui\testing\tests\test_gui.py", line 154, in test_qt_process_events_process_all
    self.assertEqual(n_left_behind_events, 0, msg)
AssertionError: 8 != 0 : Expected 10 events processed on the objects and zero events left on the queue after running process_cascade_events. Found 2 processed with 8 left behind.

@rahulporuri rahulporuri merged commit a0db8c0 into master Apr 26, 2021
@rahulporuri rahulporuri deleted the rahulporuri-patch-1 branch April 26, 2021 14:06
@rahulporuri rahulporuri moved this from In progress to Done in Enthought OSS Q2 2021 Apr 26, 2021
@aaronayres35
Copy link
Contributor

xref: #951

@rahulporuri rahulporuri moved this from Done to Sprint 2 : 19 April - 30 April 2021 in Enthought OSS Q2 2021 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q2 2021
  
Sprint 2 : 19 April - 30 April 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants