Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose notify interval in VideoEditor #1609

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

mdsmarte
Copy link
Contributor

@mdsmarte mdsmarte commented Apr 26, 2021

Follow up to PR #745 that adds the ability to control the notify interval of the media player.

When running the VideoEditor demo, you should see position updates occur approx every 0.5s now (previously 1s).

@mdsmarte mdsmarte requested a review from jwiggins April 26, 2021 16:35
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM but with one question.

traitsui/qt4/video_editor.py Show resolved Hide resolved
@mdsmarte mdsmarte merged commit 6f66e8d into master Apr 27, 2021
@rahulporuri rahulporuri deleted the maint/video-editor-notify branch July 6, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants