Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code handling old/outdated versions of wx #1614

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

rahulporuri
Copy link
Contributor

At the moment, we only support the latest versions of WxPython (4.x) so this PR removes the code which was explicitly handling these old/outdated versions.

	modified:   traitsui/tests/editors/test_range_editor_spinner.py
	modified:   traitsui/wx/range_editor.py
@rahulporuri rahulporuri added this to In progress in Enthought OSS Q2 2021 Apr 27, 2021
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 6bd53af into master Apr 27, 2021
@rahulporuri rahulporuri deleted the cln/remove-wx-version-handling branch April 27, 2021 11:50
@rahulporuri rahulporuri moved this from In progress to Done in Enthought OSS Q2 2021 Apr 27, 2021
@rahulporuri rahulporuri moved this from Done to Sprint 2 : 19 April - 30 April 2021 in Enthought OSS Q2 2021 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q2 2021
  
Sprint 2 : 19 April - 30 April 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants