Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EnumEditor import in table_filter into the methods that need it #1616

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Move EnumEditor import in table_filter into the methods that need it #1616

merged 2 commits into from
Apr 28, 2021

Conversation

rahulporuri
Copy link
Contributor

Importing EnumEditor directly from the traitsui.editors.enum_editor module isnt enough because the traitsui.editors.__init__ module imports all of the editors -like the traitsui.editors.api module.

So, the best fix for the moment is to simply move the EnumEditor into the specific method where the object is needed.

fixes #575

FIX : Move EnumEditor import into the methods which need it
75c030c 
importing EnumEditor directly from the enum_editor module isnt enough
because the traitsui.editors init module imports all of the editors -
like the traitsui.editors.api module

so, the best fix for the moment is to simply move the EnumEditor into
the specific method where the object is needed

	modified:   traitsui/table_filter.py
aaronayres35
aaronayres35 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tested import traitsui.table_filter on this branch and I no longer see the error

traitsui/table_filter.py Outdated Show resolved Hide resolved
@rahulporuri
Copy link
Contributor Author

appveyor crashed when trying to use edm. restarting the job

HTTPSConnectionPool(host='enthought-platform-eds.s3.us-east-1.amazonaws.com', port=443): Max retries exceeded with url: /4cb93669ee9fd0f3d7d33e575eba1246?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVEKSXEUY7WUWMADQ%2F20210428%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20210428T091113Z&X-Amz-Expires=604800&X-Amz-SignedHeaders=host&X-Amz-Signature=b5c5d8d17ff79e3274601e5ab0c12bd1f658928e0b926ccc76642e745e938f67 (Caused by ProtocolError('Connection aborted.', BadStatusLine("''",)))

@rahulporuri rahulporuri merged commit b6a7844 into master Apr 28, 2021
@rahulporuri rahulporuri deleted the fix/575 branch April 28, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronayres35 aaronayres35 aaronayres35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError due to circular imports
2 participants
@rahulporuri @aaronayres35