Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup imports in "traitsui.editors.*" #1619

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

rahulporuri
Copy link
Contributor

There were a number of FIXMEs in the imports in traitsui.editors.* which this PR addresses and cleans up - converting them into explicit imports instead of implicit imports.

There were a number of FIXMEs in the imports in traitsui.editors.* which
this PR addresses and cleans up - converting them into explicit imports
instead of implicit imports
@rahulporuri rahulporuri added this to In progress in Enthought OSS Q2 2021 Apr 27, 2021
@rahulporuri
Copy link
Contributor Author

The following seg fault is observed on travis - and this looks intermittent so im restarting the job for now

test_livemodal_view_application_ok (traitsui.tests.test_view_application.TestViewApplication) ... Fatal Python error: Segmentation fault
Current thread 0x00007fec931a4700 (most recent call first):

  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/qt4/ui_base.py", line 86 in add_button
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/qt4/ui_live.py", line 202 in init
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/qt4/ui_base.py", line 298 in display_ui
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/qt4/ui_live.py", line 75 in _ui_dialog
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/qt4/ui_live.py", line 59 in ui_livemodal
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/qt4/toolkit.py", line 165 in ui_livemodal
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/ui.py", line 238 in ui
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/view.py", line 454 in ui
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/qt4/view_application.py", line 136 in __init__
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/qt4/view_application.py", line 94 in view_application
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/qt4/toolkit.py", line 243 in view_application
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/tests/test_view_application.py", line 76 in view_application
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/traitsui/tests/test_view_application.py", line 163 in test_livemodal_view_application_ok
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/case.py", line 605 in run
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/case.py", line 653 in __call__
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/runner.py", line 176 in run
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/main.py", line 256 in runTests
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/main.py", line 95 in __init__
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/unittest/__main__.py", line 18 in <module>
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/coverage/execfile.py", line 183 in run_python_file
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/coverage/execfile.py", line 113 in run_python_module
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/coverage/cmdline.py", line 627 in do_run
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/coverage/cmdline.py", line 483 in command_line
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/coverage/cmdline.py", line 756 in main
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/site-packages/coverage/__main__.py", line 8 in <module>
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/runpy.py", line 85 in _run_code
  File "/home/travis/.edm/envs/traitsui-test-3.6-pyqt/lib/python3.6/runpy.py", line 193 in _run_module_as_main
Command "python -X faulthandler -W default -m coverage run -p -m unittest discover -v traitsui" exited with segmentation fault (-11)

Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 42a42d5 into master Apr 27, 2021
@rahulporuri rahulporuri deleted the cln/update-editors-factory-imports branch April 27, 2021 23:35
@rahulporuri rahulporuri moved this from In progress to Done in Enthought OSS Q2 2021 Apr 27, 2021
@rahulporuri rahulporuri moved this from Done to Sprint 2 : 19 April - 30 April 2021 in Enthought OSS Q2 2021 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q2 2021
  
Sprint 2 : 19 April - 30 April 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants