Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User facing docs for VideoEditor #1630

Merged
merged 4 commits into from
May 5, 2021
Merged

User facing docs for VideoEditor #1630

merged 4 commits into from
May 5, 2021

Conversation

rahulporuri
Copy link
Contributor

This PR adds a small new "VideoEditor" section in the advanced factories page of the traitsui user docs. The section links to the traitsui demos page and the demo page has been updated to link to the new video editor demo

The video editor section includes a rather large note containing information regarding platform support for the video editor and what codecs need to be installed to get things working. Note that this advice was extracted from #745 (comment). Thanks @mdsmarte for putting together this information.

fixes #1629

This commit adds a small new VideoEditor in the advanced factories page
of the traitsui user docs. The section links to the traitsui demos page
and the demo page has been updated to link to the new video editor demo

the video editor section includes a rather large note containing
information regarding platform support for the video editor and what
codecs need to be installed to get things working

fixes #1629

	modified:   docs/source/demos/index.rst
	modified:   docs/source/traitsui_user_manual/factories_advanced_extra.rst
@corranwebster

This comment has been minimized.

Poruri Sai Rahul added 3 commits May 5, 2021 17:23
	modified:   docs/source/traitsui_user_manual/factories_advanced_extra.rst
similar to what we do for the other standard editors examples

	modified:   traitsui/examples/demo/Standard_Editors/VideoEditor_demo.py
	modified:   docs/source/traitsui_user_manual/factories_advanced_extra.rst
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 3a3ee25 into master May 5, 2021
@rahulporuri rahulporuri deleted the doc/videoeditor branch May 5, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document new VideoEditor in Advanced Trait Editors
4 participants