Add item_factory callable for specifying creation of new list items #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hought/traitsui into add-default_factory-callable
aaronayres35
changed the title
|
Actually, although this is good, might want to pass additional arguments to the default factory in case what you create depends on the context. |
rahulporuri
approved these changes
May 5, 2021
Comment on lines
+354
to
+360
| try: | ||
| self.value = list[:index] + [value] + list[index:] | ||
| # if the default new item is invalid, we just don't add it to the list. | ||
| # traits will still give an error message, but we don't want to crash | ||
| except TraitError: | ||
| from traitsui.api import raise_to_debug | ||
| raise_to_debug() |
There was a problem hiding this comment.
question : looks like we missed this in the earlier PR
There was a problem hiding this comment.
yeah wx got neglected before 😞
aaronayres35
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up PR to #1559
closes #1627
This PR adds a
default_factoryCallabletrait on theListEditorfactory class. Then it uses this callable to create a new item in theadd_itemmethods of the toolkit specific editors if it was specified. Otherwise, it defaults back to the old behavior of using the default value for the trait type in the list.