skip video editor test without numpy / move numpy import to when it is needed / list numpy as test dependency #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… needed, and add numpy as a test dependency
aaronayres35
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1636
This PR does a number of things. It moves the
import numpy as npstatement from the top of the module to inside the__init__method so it is only imported when needed. It skips the video editor tests when numpy is not installed. (both of these follow exactly was it done for theDataFrameEditor.Lastly, I added
numpyas a test dependency inextras_require. My understanding was that if I dopip install -e .[test]I should have all the deps needed to run every test in the test suite