Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better flake8 checks #1754

Merged
merged 4 commits into from Sep 22, 2021
Merged

Better flake8 checks #1754

merged 4 commits into from Sep 22, 2021

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Sep 21, 2021

Fixes #1751 and hopefully prevents similar issues in the future (implements my suggestion for that issue).

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

@corranwebster corranwebster changed the title Enh/better flake8 checks Better flake8 checks Sep 21, 2021
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I often run flake8 not through etstool.py, so I'm strongly in favour of having configuration options in configuration files where possible.

@@ -0,0 +1,3 @@
[flake8]
ignore = E266,W503,E722,E731,E741
per-file-ignores = */api.py:F401
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: missing newline

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I just tried to fix this using a suggestion, but it's not clear whether that's possible.)

@corranwebster corranwebster merged commit 9f4acb8 into main Sep 22, 2021
@corranwebster corranwebster deleted the enh/better-flake8-checks branch September 22, 2021 07:46
@corranwebster corranwebster restored the enh/better-flake8-checks branch September 22, 2021 09:37
@corranwebster corranwebster deleted the enh/better-flake8-checks branch September 22, 2021 09:41
@corranwebster corranwebster mentioned this pull request Sep 22, 2021
1 task
@corranwebster corranwebster restored the enh/better-flake8-checks branch September 22, 2021 16:45
@corranwebster corranwebster deleted the enh/better-flake8-checks branch September 22, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameErrors in the codebase
2 participants